Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move events repository here #239

Open
wants to merge 56 commits into
base: master
from

Conversation

@RDIL
Copy link
Member

commented May 14, 2019

Checklist:

  • Base files
  • Includes
  • Layouts
  • Data
  • Posts
RDIL added 6 commits May 14, 2019
@RDIL

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@jancborchardt would you be ok with leaving the events before 2016 out?

RDIL added 3 commits May 14, 2019

@RDIL RDIL changed the title Begin events port Move events repository here May 14, 2019

RDIL added 2 commits May 14, 2019

@RDIL RDIL marked this pull request as ready for review May 14, 2019

@jancborchardt

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@jancborchardt would you be ok with leaving the events before 2016 out?

Since it shows the development of the collective and how long it has been around, we should definitely have all content and all events in.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@RDIL is there a specific issue with pre-2016 events, or how come you ask? :)

RDIL added 12 commits May 30, 2019
@RDIL

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

@jancborchardt @evalica We should be done

@jancborchardt

This comment has been minimized.

Copy link
Member

commented May 31, 2019

@AnXh3L0 @dmichl @ei8fdb @evalica @Jc-L @simonv3 could some of the Jekyll experts check this out? :)

@RDIL it would be cool if you can squash the commits into one. (It’s also fine if not, we will then just squash on merging. :)

@RDIL

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Hey @jancborchardt can OSD also consider moving on to Netlify?

Its free, connects to GitHub, and creates deploy previews of pull requests so you can see what it will look like once the PR is merged.

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@RDIL we discussed having something like Netlify in the past, but we’d like to not introduce more stuff to manage. GitHub Pages is quite ok for our use-case, and we are not locked-in to a specific provider. (e.g. we could switch to GitLab pages almost instantly).

@AnXh3L0 could you check this pull request out too so we can solve this before jumping into the redesign? :) (ref #242 )

@RDIL RDIL requested a review from evalica Jun 20, 2019

@AnXh3L0

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

@jancborchardt I will check this PR today.

@AnXh3L0

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

I checked the PR and most pages, things are looking kinda ok, but the /events page is empty when I build the site locally (just bundle exec jekyll serve, no other command issued).

image

@vinitshahdeo
Copy link
Member

left a comment

My bad!
Shouldn't be approved, yet changes are required.

@AnXh3L0

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@RDIL Is there anything I'm missing about the Events page showing "Page not found" when I build it locally? Otherwise everything else seems ok to me.

@RDIL

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

I can't check now, but I will later

@elioqoshi

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

It's a bit of a pity to start a PR and abandon it since the new website work was based on this as well. It would be great if someone could take a look at this since we are kind of stuck.

@RDIL RDIL requested a review from vinitshahdeo Jul 2, 2019

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@RDIL @vinitshahdeo @AnXh3L0 @evalica @elioqoshi I’m back from vacation now too. Is there any specific list of issues that are left to fix? Let’s split it into blockers we need to fix before merging, and things which can wait for polishing.

@RDIL

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

I will try to test it out so we can move on from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.