Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Item Form is not working -BUG #2120

Closed
rodigilbergonzalez-4th opened this issue Sep 4, 2018 · 12 comments
Closed

New Item Form is not working -BUG #2120

rodigilbergonzalez-4th opened this issue Sep 4, 2018 · 12 comments
Milestone

Comments

@rodigilbergonzalez-4th
Copy link

I using the DEMO version

then I tried to enter a new item for testing purposes but the New item form wont work
Form was properly filled
image

then the button submit was clicked and nothing happens,
then the button new was clicked and nothing happens
image

@SteveIreland
Copy link
Collaborator

It most likely needs that table change pull request that is pending.

@daN4cat
Copy link
Collaborator

daN4cat commented Sep 4, 2018

@SteveIreland not sure that makes any difference. What is the actual change in that PR?

@SteveIreland
Copy link
Collaborator

In my tests I believe it was the missing insert statement but I believe you have sorted it all out now

@odiea
Copy link
Collaborator

odiea commented Sep 5, 2018

See issue #2095

Unknown column 'custom1' in 'field list'
This is the error that is returned when submitting a new item.
INSERT INTO ospos_items (name, description, category, item_type, stock_type, supplier_id, item_number, cost_price, unit_price, reorder_level, receiving_quantity, allow_alt_description, is_serialized, qty_per_pack, pack_name, low_sell_item_id, deleted, custom1, custom2, custom3, custom4, custom5, custom6, custom7, custom8, custom9, custom10, tax_category_id) VALUES ('test', '', 'misc', '0', '0', NULL, NULL, 10, 20, 1, 1, 0, 0, 1, 'Each', -1, 0, '', '', '', '', '', '', '', '', '', '', '')

Filename: models/Item.php

Line Number: 401

@SteveIreland
Copy link
Collaborator

Sounds like the attribute project has injected itself into the process. This cowboy votes for going ahead and merging it so we can clean it up (plus I have ulterior motives regarding my own project as mentioned on another thread).

@daN4cat
Copy link
Collaborator

daN4cat commented Sep 5, 2018

I want to fix the text box size issue first and then move to this one. But if my memory is not mistaken there are still issues to be sorted.

@jekkos
Copy link
Member

jekkos commented Sep 6, 2018

I think this is because the sqlscript container is not using the branch tag correctly

@jekkos
Copy link
Member

jekkos commented Sep 6, 2018

Issue is resolved on demo. I stopped using the database.sql from sqlscript container (as it should be copied to the container locally anyway). Think if we start from the 3.0 version and then add migrations in every branch we should be fine.

@jekkos jekkos closed this as completed Sep 6, 2018
@daN4cat
Copy link
Collaborator

daN4cat commented Sep 6, 2018

Yes

@SteveIreland
Copy link
Collaborator

I'm good with that too. There are a couple of changes to tables.sql that I need to back out to make it 100% compliant but I have already included those changes in the India GST project.

@rodigilbergonzalez-4th
Copy link
Author

Thanks, Guys.

just if someone could please confirm that this does not affect the latest release version I will appreciate it.

@jekkos
Copy link
Member

jekkos commented Sep 6, 2018

No it does not affect the code in master.

@daN4cat daN4cat added this to the 3.3.0 milestone Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants