New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cities polygon #21

Merged
merged 3 commits into from Feb 26, 2016

Conversation

Projects
None yet
2 participants
@kiote
Contributor

kiote commented Feb 25, 2016

This PR represents city polygon endpoint and some refactoring of previous (country polygon) code to make it more reusable.

@kiote

This comment has been minimized.

Show comment
Hide comment
@kiote

kiote Feb 25, 2016

Contributor

I commented out some tests here to restore them in a final (with regions) PR.

Contributor

kiote commented Feb 25, 2016

I commented out some tests here to restore them in a final (with regions) PR.

@pwalsh

This comment has been minimized.

Show comment
Hide comment
@pwalsh

pwalsh Feb 26, 2016

Member

I don't like the commenting tests, and I would not normally merge code with that. But I'll do it in this case in the expectation that the next PR, which finishes the task, fixes that

Member

pwalsh commented Feb 26, 2016

I don't like the commenting tests, and I would not normally merge code with that. But I'll do it in this case in the expectation that the next PR, which finishes the task, fixes that

pwalsh added a commit that referenced this pull request Feb 26, 2016

@pwalsh pwalsh merged commit 89173c3 into openspending:master Feb 26, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 94.989%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment