/os-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly restore field options #103

Merged
merged 1 commit into from Dec 6, 2016

Conversation

Reviewers
No reviews
Assignees

@akariv akariv

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kravets-levko @akariv
@kravets-levko
Contributor

kravets-levko commented Dec 6, 2016

Format (and probably other extra options) were incorrectly restored when loading existing datapackage file.
Do not merge it until PR openspending/os-types/pull/5 accepted.

@kravets-levko kravets-levko added the in progress label Dec 6, 2016

@kravets-levko kravets-levko assigned akariv Dec 6, 2016

@akariv

This comment has been minimized.

Show comment
Hide comment
@akariv

akariv Dec 6, 2016

Contributor

Looks good.
Holding until the os-types PR is merged.
Contributor

akariv commented Dec 6, 2016

Looks good.
Holding until the os-types PR is merged.

@akariv akariv merged commit ea2dbe1 into openspending:master Dec 6, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akariv akariv removed the in progress label Dec 6, 2016

@kravets-levko kravets-levko deleted the kravets-levko:bug/format-not-restored branch Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment