Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: openssh/openssh-portable
base: master
Choose a base ref
...
head repository: Jakuje/openssh-portable
compare: jjelen-pkcs11
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 17 files changed
  • 1 contributor

Commits on Aug 17, 2020

  1. PKCS#11 URI from Fedora 

     * Print PKCS#11 URIs from ssh-keygen
 * Accept PKCS#11 URIs in -i argument to ssh
 * Allow PKCS#11 URI specification in ssh_config
 * Fallback to p11-kit-proxy
 * PKCS#11 URI support for ssh-add and ssh-agent
  * internal representation is URI
 * Allow to specify pin-value in URI to avoid interactive prompts

Currently recognized and used parts of PKCS#11 URI:
 * path (optional)
  * token
  * id
  * manufacturer
  * (library-manufacturer)
 * query (optional)
  * module-path
  * pin-value

Unit test for PKCS#11 URIs

 * test PKCS#11 URI parser, generator
 * test percent_encodeer and decoder

Regression tests for PKCS#11 URI support

 * soft-pkcs11.so  from people.su.se/~lha/soft-pkcs11
  * Return correct CKR for unknown attributes
  * Adjust and build it with regress tests (allowing agent-pkcs11 test)
 * Test PKCS#11 URIs support with soft-pkcs11
  * Direct usage from commandline (URI, provider and combination)
  * Usage from configuration files
  * Usage in ssh-agent (add, sign, remove)
  * Make sure it is built with correct paths
    @Jakuje
    Jakuje committed Aug 17, 2020
    6d12874

  2. Do not reset PIN when provider returns multiple slots

    @Jakuje
    Jakuje committed Aug 17, 2020
    9791d7c

  3. Do not crash when adding invalid path to pkcs11 module in agent

    @Jakuje
    Jakuje committed Aug 17, 2020
    57da401