Fixing compilation issue for OPENSSH with no support for OPENSSL_HAS_ECC #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the KEX_ECDH_SHA2 related cases should come under OPENSSL_HAS_ECC macro since the functions called under the switch cases are available only under OPENSSL_HAS_ECC macro
SK851831
changed the title
|
This was already fixed by97370f6c2c3b825f8c577b7e6c00b1a98d30a6cf (after 8.0) which adds no-op implementations of those functions without adding the added maintenance of those ifdefs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
All the KEX_ECDH_SHA2 related cases should come under OPENSSL_HAS_ECC macro since the definitions of the functions called under these switch cases are available only under OPENSSL_HAS_ECC macro causing OPENSSH to fail in compilation without OPENSSL_HAS_ECC macro