Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove perm_ok argument from sshkey_load_private_type #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jitendrasharma1989
Copy link
Contributor

Remove perm_ok, which could potentially be used to check
for private identification file permissions.
But as sshkey_load_private_type would return
SSH_ERR_KEY_BAD_PERMISSIONS for bad permission.
Hence perm_ok seems redundant.

Remove perm_ok, which could potentially be used to check
for private identification file permissions.
But as sshkey_load_private_type would return
SSH_ERR_KEY_BAD_PERMISSIONS for bad permission.
Hence perm_ok seems redundant.
@jitendrasharma1989
Copy link
Contributor Author

@djmdjm , @daztucker could you please help in reviewing this patch.
The idea of this patch came from TODO list, which says to fix XXX comments.

I have submitted this patch in openssh-unix-dev mailing list also.
In continuation to this patch i have also submitted another patch in mailing list.(I have not yet created Pull request for that another patch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant