Print comment when converting from/to RFC4716. Bugzilla #2180 #177
+64
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting public keys from RFC4716 to ssh2 format, preserve the comment field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As reported in Bugzilla #2180, preserve the comment field when converting public keys from and to RFC4716 format, On export to RFC4716, this change will preserve a comment if one exists or if not, keep the standard user@host comment. On import, it will keep a comment if one exists.
RFC4716 sec 3 does allow multi-line comments indicated by a '', however as supporting that would require a larger code change I haven't included support for it here. If multi-line comments are desirable I'm happy to implement them next.
Some existing unit tests have been change to only check the algorithm and key, as the user@host comment will change per machine. New unit tests are added to test the new comment features.