Improve sending struct passwd #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to be a wild pointer in peer process, if a new pointer member is added.
yuichiro-naito
force-pushed
the
improve_sending_struct_passwd
branch
from
7178ee1
to
3d74b75
Compare
|
This was fixed in b2bcec1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull request avoids sending pointer values in struct passwd.
It is possible to be a wild pointer in peer process, if a new pointer member is added.
And I believe that one ToDo comment will be finished.
Background:
I made a patch for FreeBSD's openssh. (c.f. my FreeBSD patch to see what I fixed)
We discussed about pointer values should not be sent to another process.
It is necessary for openssh and I think the ToDo comment says as same as well.