Ignoring comments at end of config file lines broke ProxyCommand. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all lines are negated from the hash-sign onwards, any existing options with embedded hash-signs are truncated. e.g. If there are bash parts that manipulate strings. The value is too free form to keep a good tab on when the hash-sign is meant to be in the value and when not. Unfortunately as 8.5 is released, there probably already exist config files that have comments at the end of options. Changed the comment remover to ignore only lines having a hash-sign as the first non-space character. This will break 8.5 configurations with hash-comments at the end of functional lines.
|
See https://bugzilla.mindrot.org/show_bug.cgi?id=3288 for the planned fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If all lines are negated from the hash-sign onwards, any existing
options with embedded hash-signs are truncated. e.g. If there are
bash parts that manipulate strings.
The value is too free form to keep a good tab on when the
hash-sign is meant to be in the value and when not.
Unfortunately as 8.5 is released, there probably already exist
config files that have comments at the end of options.
Changed the comment remover to ignore only lines having a
hash-sign as the first non-space character. This will break 8.5
configurations with hash-comments at the end of functional lines.