Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support of RFC 6594 #259

Closed
wants to merge 1 commit into from
Closed

Conversation

beldmit
Copy link

@beldmit beldmit commented Jun 18, 2021

Set SHA256 as a default digest for RSA/DSA SSHFP records

Set SHA256 as a default digest for RSA/DSA SSHFP records
Copy link
Contributor

@daztucker daztucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that doing this will mean that any currently-working configurations relying on SHA1 fingerprints will stop working unless the DNS also contains the corresponding SHA256 records.

edit: actually there is a check hostkey_digest_type != dnskey_digest_type which will override the default type. If I'm reading this right the check inside the loop means it'll always end up using the hash algos returned by DNS and your change won't have any effect. (Whether or not its current behaviour is desirable is a separate question).

@daztucker
Copy link
Contributor

The behaviour was changed in b75a80f such that it'll verify every fingerprint available to it and bail if any fail to match.

Additional discussion available in https://bugzilla.mindrot.org/show_bug.cgi?id=3322

@daztucker daztucker closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants