Class-imposed login restrictions (simplified) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated my patch not to log a message when authentication is failed. Please review my code for merging. |
|
I'd suggest squashing the two commits into one. I've mentioned this pull request on the openssh mailing list, and am preparing to update FreeBSD's base system OpenSSH w/ this patch. |
|
Review to apply this change to (the older) OpenSSH in the FreeBSD base system: https://reviews.freebsd.org/D31760 |
If the following functions are available, add an additional check if users are allowed to login imposed by login class. * auth_hostok(3) * auth_timeok(3) These functions are implemented on FreeBSD.
yuichiro-naito
force-pushed
the
class_imposed_login_restrictions_attempt_2
branch
from
2b4adf5
to
974a048
Compare
|
Thanks for the comment. |
freebsd-git
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Sep 1, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760
|
Now committed to FreeBSD base system: https://reviews.freebsd.org/R10:27ceebbc2402e4c98203c7eef9696f4bd3d326f8 |
emaste
added a commit
to emaste/freebsd
that referenced
this pull request
Sep 15, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760 (cherry picked from commit 27ceebb)
emaste
added a commit
to emaste/freebsd
that referenced
this pull request
Sep 15, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760 (cherry picked from commit 27ceebb)
freebsd-git
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Sep 15, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760 (cherry picked from commit 27ceebb)
freebsd-git
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Sep 15, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760 (cherry picked from commit 27ceebb)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Dec 29, 2021
Login class-based restrictions were introduced in 5b400a3. The code was adapted for sshd's Capsicum sandbox and received many changes over time, including at least fc3c19a, bd393de, and e8c56fb. During an attempt to upstream the work a much simpler approach was suggested. Adopt it now in the in-tree OpenSSH to reduce conflicts with future updates. Submitted by: Yuchiro Naito (against OpenSSH-portable on GitHub) Obtained from: openssh/openssh-portable#262 Reviewed by: allanjude, kevans MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the following functions are available, add an additional check if users are allowed to login imposed by login class.
These functions are implemented on FreeBSD.
After I got the advice in the #261,
I changed my patch not to leak any informations includes behaviors when authentication is failed.