Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSH's ssh-keygen can't parse encrypted PKCS#8 private keys being … #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beldmit
Copy link

@beldmit beldmit commented Jul 21, 2021

…built against openssl 3.0

See bz#3330

Copy link
Contributor

@daztucker daztucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if ERR_R_INTERRUPTED_OR_CANCELLED is not defined, ERR_LIB_CRYPTO should still return SSH_ERR_INVALID_FORMAT (ie the scope of the ifdef should be smaller)?

@beldmit
Copy link
Author

beldmit commented Jul 22, 2021

Yes, we could narrow the scope, but we shouldn't get a ERR_LIB_CRYPTO in case when we didn't build with OpenSSL 3.0 at all.

@beldmit
Copy link
Author

beldmit commented Jul 22, 2021

I reduced the #ifdef scope.

@beldmit
Copy link
Author

beldmit commented Jul 22, 2021

make tests passed successfully, both with and without this patch.

@daztucker
Copy link
Contributor

I added a comment to the bugzilla bug with more detail, but I was not able to reproduce the problem built against the OpenSSL 3.0.0 dev branch head.

I also added a regression test in 8b7af02 which I think should catch the problem you're describing (but since I can't reproduce it, I'm not sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants