Be strict about masklength #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strtoul is too lax about characters which are used for numbers.
Manually check that masklength starts with digit.
PoC
Add following match block to your sshd_config
Match address "127.0.0.1/ +0032"
ForceCommand ls
If you access your server with `ssh 127.0.0.1` then ls is executed.
This behaviour is unexpected as masklength should not be valid.
|
committed upstream and synced back as fda1eaaec - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strtoul is too lax about characters which are used for numbers.
Manually check that masklength starts with digit.
PoC
Add following match block to your sshd_config
Match address "127.0.0.1/ +0032"
ForceCommand ls
If you access your server with
ssh 127.0.0.1then ls is executed.This behaviour is unexpected as masklength should not be valid.
Shoutout to @c3h2_ctf