ssh-agent: remove all keys upon SIGUSR1.. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah. Merde! Sorry, i thought "mergeable" meant the pull request! |
|
..and one more sorry, this was not meant to be closed. I might become a github expert. |
|
This looks good to me and the better signal handling could allow us to make Would appreciate @daztucker taking a look at this too |
|
(It is all taken from sshd.c of course. Only to mention it. I .. do not implement this cleanup like it is done in sshd.c in this context here now!?!) |
sdaoden
force-pushed
the
remove_all_2
branch
from
5379896
to
0da49a8
Compare
|
But surely not because of this changeset, no? |
sdaoden
force-pushed
the
remove_all_2
branch
from
0da49a8
to
762b6c4
Compare
With the advent of per-user temporary directories it became
hard for an administrator to remove all keys from all running
ssh-agent instances; what formerly could be done like so
if command -v ssh-add >/dev/null 2>&1; then
for a in /tmp/ssh-*/agent.*; do
[ -e "$a" ] || continue
act "SSH_AUTH_SOCK=\"$a\" ssh-add -D </dev/null >/dev/null 2>&1 &"
inc
done
fi
has become a major undertaking, especially with even more
containerization. Being able to remove all keys from all agents
with a single command seems so desirable that it is available in
other agents in the software world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the advent of per-user temporary directories it became
hard for an administrator to remove all keys from all running
ssh-agent instances; what formerly could be done like so
if command -v ssh-add >/dev/null 2>&1; then
for a in /tmp/ssh-/agent.; do
[ -e "$a" ] || continue
act "SSH_AUTH_SOCK="$a" ssh-add -D </dev/null >/dev/null 2>&1 &"
inc
done
fi
has become a major undertaking, especially with even more
containerization. Being able to remove all keys from all agents
with a single command seems so desirable that it is available in
other agents in the software world.