Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure for clang 15 #349

Closed
wants to merge 1 commit into from
Closed

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Oct 13, 2022

See https://bugzilla.mindrot.org/show_bug.cgi?id=3482

And https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics:

The -Wimplicit-int warning diagnostic now defaults to an error in C99 and
later. Prior to C2x, it may be downgraded to a warning with
-Wno-error=implicit-int, or disabled entirely with -Wno-implicit-int. As of
C2x, support for implicit int has been removed, and the warning options will
have no effect. Specifying -Wimplicit-int in C89 mode will now issue warnings
instead of being a noop.

The configure scripts shouldn't be using main() {...} but int main() {...}.

@haampie
Copy link
Contributor Author

haampie commented Oct 13, 2022

@djmdjm the current ci failure seems unrelated, it's on the master branch too?

Would it make sense to add CI for clang 15 to catch other errors?

@daztucker
Copy link
Contributor

@djmdjm the current ci failure seems unrelated, it's on the master branch too?

Yes, the failure on Mac OS X is unrelated (we know what broke, we're just waiting for some more detail on the thing the last commit was intended to fix so we can fix it while also unbreaking OS X.

Would it make sense to add CI for clang 15 to catch other errors?

Yes, but we are constrained to the versions available on the runners supplied by github (short of building clang as part of each test, but that's not something I would want to do).

@daztucker
Copy link
Contributor

Applied, thanks.

@daztucker daztucker closed this Oct 13, 2022
@haampie haampie deleted the fix/int-main branch October 13, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants