sftp: implement session timeout to automatically close idle connections #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See https://bugzilla.mindrot.org/show_bug.cgi?id=3484
Currently there is no way for the sftp backend (
sftp-serverorinternal-sftp) to close idle connections (by idle I mean no order sent for some time by thesftpclient).This is very problematic for SFTP servers because clients can remain connected, which consumes file descriptors and resources in general, causing potentially system limits to be reached.
This is a case I handled recently, where system-wide file descriptors were exhausted, due to left-opened sftp sessions + corresponding systemd sessions.
There are
ClientAlive*properties but these only work for dead clients.This PR implements the functionality through a new
-t <timeout>option passed tosftp-serverorinternal-sftpexecutables.