File exists control added before opening remote connection (SCP) #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have such a long password for the remote PC and getting
No such file or directory
after writing the password is so annoying. This is why I add a check before creating a connection. I didn't remove the existing control after entering the password because at that time folder can be removed.Tests are successful.
https://github.com/macorapci/openssh-portable/blob/ca9bb068015321c2045d02c5ba7fa4616abba4d8/scp.c#L682
I wanna add the condition for
tolocal
but the tests fail so I add it with the comment line. I can delete the line if it breaks something.