sftp-server: Fix home-directory extension to match the specification #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galorithm
reviewed
Mar 26, 2024
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Jakuje
force-pushed
the
sftp-home-directory
branch
from
233414b to
c2b9741
Compare
Contributor
Author
|
@djmdjm any chance somebody would be able to look into this? |
Contributor
|
Thanks, committed upstream and synced back as 385ecb3 |
Contributor
The empty string username means that the name of the user is empty? How can I create an empty string username? |
Contributor
Author
No, it means the string in the SFTP message that represents username is empty. For reference, see the SFTP protocol extension implemented by OpenSSH in PROTOCOL: https://github.com/openssh/openssh-portable/blob/master/PROTOCOL#L697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
home-directoryextension does not match the specification in PROTOCOL. Right now, it:The proposed change updates the extension to catch both of the corner cases.