Certificateidentityhandling #53
Closed
+124
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. IdentitiesOnly=yes not working as expected when certificates are specified. 2. IdentityFile=/private/key not working when certificate but no public key is present (regression from earlier versions). 3. CertificateFile=/path/to/key-cert.pub not implicitly picking up private key (as it does in the opposite direction). Next commits fix these.
…yes is specified, then do not load implicit identities.
public key file. Prior to 4e44a79 (in 7.2) it was possible to use IdentityFile to point to a private key file, e.g. "id_shortlived_rsa", with no corresponding public key file (such as "id_shortlived_rsa.pub") and instead a public certificate, e.g. "id_shortlived_rsa-cert.pub". Upgrading to 7.2 broke our users configuration files and tools that relied on this. While we were able to workaround by changing our tooling to produce the ".pub" files, this is a regression from previous behaviour. (The reason we deliberately didn't produce the ".pub" files is that our workflow regularly generates new private keys for users, and then issues certificates for them. We prefer not to put the "id_shortlived_rsa.pub" on disk, lest users get confused and start putting that in authorized_keys files, or linking to their Git accounts.)
…lent name when present, if no other IdentifyFiles are explicitly listed. This mirrors the current behaviour where a Certifcate file is loaded for a key if present.
|
Please use https://bugzilla.mindrot.org/ instead of github PRs in future. We only use this site as a mirror and seldom check the PR queue (thus the inactivity). AFAIK there have been a few fixes to bare cert keys since this was reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Creating pull request to link to in mailing list discussion.