From 1b285ac13726f443d1d737a1e2389ba6e17ba98f Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Fri, 22 Jul 2022 14:23:25 +0100 Subject: [PATCH] Remove a redundant TODO If read_ahead data is left over when a record layer closes down, there is already code present to push into the "next" BIO. So the TODO removed here is no longer relevant. Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18132) --- ssl/record/methods/tls_common.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ssl/record/methods/tls_common.c b/ssl/record/methods/tls_common.c index 8b541061ba18f..4c999c52e8344 100644 --- a/ssl/record/methods/tls_common.c +++ b/ssl/record/methods/tls_common.c @@ -1080,10 +1080,6 @@ tls_int_new_record_layer(OSSL_LIB_CTX *libctx, const char *propq, int vers, * that is destined for a higher protection level. To simplify the logic * we don't support that at this stage. */ - /* - * TODO(RECLAYER): Handle the case of read_ahead at the application - * level and a key update/reneg occurs. - */ p = OSSL_PARAM_locate_const(options, OSSL_LIBSSL_RECORD_LAYER_PARAM_READ_AHEAD); if (p != NULL && !OSSL_PARAM_get_int(p, &rl->read_ahead)) { RLAYERfatal(rl, SSL_AD_INTERNAL_ERROR, SSL_R_FAILED_TO_GET_PARAMETER);