Skip to content

Commit

Permalink
Refactor BN_R_NO_INVERSE logic in internal functions
Browse files Browse the repository at this point in the history
Closes #12129

As described in #12129 the
readability of the internal functions providing the two alternative
implementations for `BN_mod_inverse()` is a bit lacking.

Both these functions are now completely internal, so we have the
flexibility needed to slightly improve readability and remove
unnecessary NULL checks.

The main changes here are:
- rename `BN_mod_inverse_no_branch()` as `bn_mod_inverse_no_branch()`:
  this function is `static` so it is not even visible within the rest of
  libcrypto. By convention upcase prefixes are reserved for public
  functions.
- remove `if (pnoinv == NULL)` checks in `int_bn_mod_inverse()`: this
  function is internal to the BN module and we can guarantee that all
  callers pass non-NULL arguments.
- `bn_mod_inverse_no_branch()` takes an extra `int *pnoinv` argument, so
  that it can signal if no inverse exists for the given inputs: in this
  way the caller is in charge of raising `BN_R_NO_INVERSE` as it is the
  case for the non-consttime implementation of `int_bn_mod_inverse()`.
- `BN_mod_inverse()` is a public function and must guarantee that the
  internal functions providing the actual implementation receive valid
  arguments. If the caller passes a NULL `BN_CTX` we create a temporary
  one for internal use.
- reorder function definitions in `crypto/bn/bn_gcd.c` to avoid forward
  declaration of `static` functions (in preparation for inlining)
- inline `bn_mod_inverse_no_branch()`.

(Backport to 1.1.1 from #12142)
(cherry picked from commit 5d8b3a3)

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #12169)
  • Loading branch information
romen committed Jun 21, 2020
1 parent 4dcfdfc commit 35bb0e4
Show file tree
Hide file tree
Showing 2 changed files with 201 additions and 185 deletions.
Loading

0 comments on commit 35bb0e4

Please sign in to comment.