Skip to content
Permalink
Browse files

Reject excessively large primes in DH key generation.

CVE-2018-0732

Signed-off-by: Guido Vranken <guidovranken@gmail.com>

(cherry picked from commit 91f7361)

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #6457)
  • Loading branch information...
guidovranken authored and mattcaswell committed Jun 11, 2018
1 parent bd45a8d commit 3984ef0b72831da8b3ece4745cac4f8575b19098
Showing with 6 additions and 1 deletion.
  1. +6 −1 crypto/dh/dh_key.c
@@ -130,10 +130,15 @@ static int generate_key(DH *dh)
int ok = 0;
int generate_new_key = 0;
unsigned l;
BN_CTX *ctx;
BN_CTX *ctx = NULL;
BN_MONT_CTX *mont = NULL;
BIGNUM *pub_key = NULL, *priv_key = NULL;

if (BN_num_bits(dh->p) > OPENSSL_DH_MAX_MODULUS_BITS) {
DHerr(DH_F_GENERATE_KEY, DH_R_MODULUS_TOO_LARGE);
return 0;
}

ctx = BN_CTX_new();
if (ctx == NULL)
goto err;

1 comment on commit 3984ef0

@kbrahmaa

This comment has been minimized.

Copy link

kbrahmaa commented on 3984ef0 Jun 30, 2018

its a return 0 or goto err ??

Please sign in to comment.
You can’t perform that action at this time.