Skip to content

Commit

Permalink
Don't try and verify signatures if key is NULL (CVE-2013-0166)
Browse files Browse the repository at this point in the history
Add additional check to catch this in ASN1_item_verify too.
  • Loading branch information
snhenson committed Jan 29, 2013
1 parent 014265e commit 62e4506
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

Changes between 1.0.1c and 1.0.1d [xx XXX xxxx]

*) Return an error when checking OCSP signatures when key is NULL.
This fixes a DoS attack. (CVE-2013-0166)
[Steve Henson]

*) Make openssl verify return errors.
[Chris Palmer <palmer@google.com> and Ben Laurie]

Expand Down
6 changes: 6 additions & 0 deletions crypto/asn1/a_verify.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ int ASN1_item_verify(const ASN1_ITEM *it, X509_ALGOR *a,

int mdnid, pknid;

if (!pkey)
{
ASN1err(ASN1_F_ASN1_ITEM_VERIFY, ERR_R_PASSED_NULL_PARAMETER);
return -1;
}

EVP_MD_CTX_init(&ctx);

/* Convert signature OID into digest and public key OIDs */
Expand Down
9 changes: 6 additions & 3 deletions crypto/ocsp/ocsp_vfy.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,12 @@ int OCSP_basic_verify(OCSP_BASICRESP *bs, STACK_OF(X509) *certs,
{
EVP_PKEY *skey;
skey = X509_get_pubkey(signer);
ret = OCSP_BASICRESP_verify(bs, skey, 0);
EVP_PKEY_free(skey);
if(ret <= 0)
if (skey)
{
ret = OCSP_BASICRESP_verify(bs, skey, 0);
EVP_PKEY_free(skey);
}
if(!skey || ret <= 0)
{
OCSPerr(OCSP_F_OCSP_BASIC_VERIFY, OCSP_R_SIGNATURE_FAILURE);
goto end;
Expand Down

0 comments on commit 62e4506

Please sign in to comment.