Skip to content

Commit 80bd7b4

Browse files
snhensonmattcaswell
authored andcommitted
Fix SRP ciphersuite DoS vulnerability.
If a client attempted to use an SRP ciphersuite and it had not been set up correctly it would crash with a null pointer read. A malicious server could exploit this in a DoS attack. Thanks to Joonas Kuorilehto and Riku Hietamäki from Codenomicon for reporting this issue. CVE-2014-2970 Reviewed-by: Tim Hudson <tjh@openssl.org>
1 parent fb0bc2b commit 80bd7b4

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

ssl/t1_lib.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,6 +1088,13 @@ void ssl_set_client_disabled(SSL *s)
10881088
c->mask_k |= SSL_kPSK;
10891089
}
10901090
#endif /* OPENSSL_NO_PSK */
1091+
#ifndef OPENSSL_NO_SRP
1092+
if (!(s->srp_ctx.srp_Mask & SSL_kSRP))
1093+
{
1094+
c->mask_a |= SSL_aSRP;
1095+
c->mask_k |= SSL_kSRP;
1096+
}
1097+
#endif
10911098
c->valid = 1;
10921099
}
10931100

0 commit comments

Comments
 (0)