Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.1 build is broken #12432

Closed
romen opened this issue Jul 13, 2020 · 1 comment
Closed

1.1.1 build is broken #12432

romen opened this issue Jul 13, 2020 · 1 comment

Comments

@romen
Copy link
Member

@romen romen commented Jul 13, 2020

Backport of #12096 to 1.1.1 broke the build as the following functions are missing:

const BIGNUM *EC_GROUP_get0_field(const EC_GROUP *group);
int EC_GROUP_get_field_type(const EC_GROUP *group);

This was also reported on openssl-users.

@romen romen self-assigned this Jul 13, 2020
romen added a commit to romen/openssl that referenced this issue Jul 13, 2020
Backport of openssl#12096 to 1.1.1 broke
the build as the following functions are missing:

    const BIGNUM *EC_GROUP_get0_field(const EC_GROUP *group);
    int EC_GROUP_get_field_type(const EC_GROUP *group);

Turns out that for the purposes of the test code, we don't really need
to differentiate between prime and binary fields, and we can directly
use the existing `EC_GROUP_get_degree()` in the same fashion as was
being done for binary fields also for prime fields.

Fixes openssl#12432
@romen romen added the branch: 1.1.1 label Jul 13, 2020
@romen romen linked a pull request that will close this issue Jul 13, 2020
1 of 1 task complete
openssl-machine pushed a commit that referenced this issue Jul 14, 2020
Backport of #12096 to 1.1.1 broke
the build as the following functions are missing:

    const BIGNUM *EC_GROUP_get0_field(const EC_GROUP *group);
    int EC_GROUP_get_field_type(const EC_GROUP *group);

Turns out that for the purposes of the test code, we don't really need
to differentiate between prime and binary fields, and we can directly
use the existing `EC_GROUP_get_degree()` in the same fashion as was
being done for binary fields also for prime fields.

Fixes #12432

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #12433)
@romen
Copy link
Member Author

@romen romen commented Jul 14, 2020

Fixed by:

  • a5b8c19 [1.1.1][test] Avoid missing EC_GROUP wrappers
@romen romen closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant