Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hardcoded implication of -new with -x509 in openssl req command breaks some use-cases #3396

Closed
t8m opened this issue May 5, 2017 · 4 comments

Comments

@t8m
Copy link
Member

t8m commented May 5, 2017

This commit
599e590
and equivalent on 1.0.2 branch broke legitimate use-case.

Namely you can generate a request with openssl req invocation and then later you want to convert it to self-signed x509 certificate via the openssl req -x509 command. The -new should not be implicitly set at least for the case the command line specifies -in <cert.req> option. There it is clear that user does not want to generate a new request but wants to read existing request file.

@t8m
Copy link
Member Author

t8m commented May 10, 2017

Ping, can you please at least tell whether you consider this breakage as a bug or not and the current behavior will be kept?

@richsalz
Copy link
Contributor

Seems like a bug. A bit tricky to figure out the right thing to do tho.

@mattcaswell
Copy link
Member

Ping @levitte. Thoughts?

@levitte
Copy link
Member

levitte commented May 10, 2017

I don't think this was an intentional breakage... In other words, I'm inclined to see this as a bug that happened with the option processing changes about a year ago...

So I'd say this is a bug and should be fixed.

t8m added a commit to t8m/openssl that referenced this issue May 11, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue openssl#3396
levitte pushed a commit that referenced this issue May 11, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue #3396

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #3437)
levitte pushed a commit that referenced this issue May 11, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue #3396

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #3437)
(cherry picked from commit 888adbe)
@levitte levitte closed this as completed May 11, 2017
t8m added a commit to t8m/openssl that referenced this issue May 17, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue openssl#3396
levitte pushed a commit that referenced this issue May 17, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue #3396

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3485)
pracj3am pushed a commit to cdn77/openssl that referenced this issue Aug 22, 2017
Allow conversion of existing requests to certificates again.
Fixes the issue openssl#3396

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#3437)
(cherry picked from commit 888adbe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants