Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CRYPTO_secure_allocated from util/missingcrypto111.txt #10611

Closed
wants to merge 1 commit into from
Closed

Remove CRYPTO_secure_allocated from util/missingcrypto111.txt #10611

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Dec 11, 2019

Followup on #10523

@levitte levitte added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels Dec 11, 2019
slontis
slontis approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label should be 1.1.1 not master?

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 12, 2019
@mspncp
Copy link
Contributor

mspncp commented Dec 12, 2019

The label should be 1.1.1 not master?

No, it's master only. The 111 suffix indicates that it lists all undocumented symbols since 1.1.1 (see commit message of a03749a).

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 13, 2019
openssl-machine pushed a commit that referenced this pull request Dec 13, 2019
@levitte
Remove CRYPTO_secure_allocated from util/missingcrypto111.txt
2e16439 
Followup on #10523

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #10611)
@levitte
Copy link
Member Author

levitte commented Dec 13, 2019

Merged.

2e16439 Remove CRYPTO_secure_allocated from util/missingcrypto111.txt

@levitte levitte closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@levitte @mspncp @slontis @paulidale