Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOST2012 TLS Supported Groups Identifiers Support #11568

Closed
wants to merge 1 commit into from

Conversation

@NMorozxov
Copy link
Contributor

@NMorozxov NMorozxov commented Apr 18, 2020

For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8

Checklist
  • documentation is added or updated
  • tests are added or updated
Copy link
Contributor

@paulidale paulidale left a comment

One of the Travis builds is quite unhappy.
Otherwise this looks good.

@NMorozxov NMorozxov force-pushed the NMorozxov:master branch Apr 19, 2020
@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 19, 2020

Got very strange errors "malloc failure" f.ex
rebased to re-trigger travis

One of the Travis builds is quite unhappy.
Otherwise this looks good.

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 19, 2020

It's a known (to me :) )problem.
I don't have a better solution for it than suppose that no-ec implies no-gost.

@NMorozxov NMorozxov force-pushed the NMorozxov:master branch Apr 19, 2020
@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 19, 2020

Ok move no-gost block under no-ec block

It's a known (to me :) )problem.
I don't have a better solution for it than suppose that no-ec implies no-gost.

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 19, 2020

Not sure it's a good solution. I think it's better to do it on the configure level.

@NMorozxov NMorozxov force-pushed the NMorozxov:master branch Apr 19, 2020
@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 19, 2020

Ok. let's try this one

Not sure it's a good solution. I think it's better to do it on the configure level.

@NMorozxov NMorozxov force-pushed the NMorozxov:master branch Apr 19, 2020
@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 19, 2020

Now travis is happy

@kaduk
Copy link
Contributor

@kaduk kaduk commented Apr 19, 2020

Not sure it's a good solution. I think it's better to do it on the configure level.

You mean, to use the disable_cascades in Configure to have no-ec imply no-gost?

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

ping @beldmit @paulidale
Travis happy waiting your reaction

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

You mean, to use the disable_cascades in Configure to have no-ec imply no-gost?

Yes. It's a disputable decision, though.

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

@beldmit What about the commit?

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

@beldmit What about the commit?

I'd recommend using disable_cascades instead of Travis tuning.

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

Where i must add disable_cascades? I must patch the Configure file ?

I'd recommend using disable_cascades instead of Travis tuning.

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

You must use the disable_cascades in Configure

For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
@NMorozxov NMorozxov force-pushed the NMorozxov:master branch to 1e82a2c Apr 20, 2020
@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

can't what fails now :(

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

Restarted the failed job

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

thx

Restarted the failed job

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 20, 2020

Running for 3h 43m... omg...

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

Restarted again.

@beldmit
Copy link
Member

@beldmit beldmit commented Apr 20, 2020

Travis failure seems not relevant here.

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Apr 22, 2020

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

openssl-machine pushed a commit that referenced this pull request Apr 22, 2020
For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #11568)
@beldmit
Copy link
Member

@beldmit beldmit commented Apr 22, 2020

Merged. Thanks!

@beldmit beldmit closed this Apr 22, 2020
@beldmit
Copy link
Member

@beldmit beldmit commented Apr 22, 2020

I was not attentive enough :(
The secbits value for GOST groups should be 128/256, so @NMorozxov could you please provide a fixup PR?

@NMorozxov
Copy link
Contributor Author

@NMorozxov NMorozxov commented Apr 22, 2020

I was not attentive enough :(
The secbits value for GOST groups should be 128/256, so @NMorozxov could you please provide a fixup PR?
Ok. I don't know can i have 2 PRs i will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants