GOST2012 TLS Supported Groups Identifiers Support #11568
Conversation
|
One of the Travis builds is quite unhappy. |
|
Got very strange errors "malloc failure" f.ex
|
|
It's a known (to me :) )problem. |
|
Ok move no-gost block under no-ec block
|
|
Not sure it's a good solution. I think it's better to do it on the configure level. |
|
Ok. let's try this one
|
|
Now travis is happy |
You mean, to use the |
|
ping @beldmit @paulidale |
Yes. It's a disputable decision, though. |
|
@beldmit What about the commit? |
I'd recommend using |
|
Where i must add disable_cascades? I must patch the Configure file ?
|
|
You must use the disable_cascades in |
For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
|
can't what fails now :( |
|
Restarted the failed job |
|
thx
|
|
Running for 3h 43m... omg... |
|
Restarted again. |
|
Travis failure seems not relevant here. |
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8 Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #11568)
|
Merged. Thanks! |
|
I was not attentive enough :( |
|
For GOST2012-GOST8912-GOST8912 IANA introduce TLS Supported Groups Identifiers
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8
Checklist