Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-dh and no-dsa #11582

Closed
wants to merge 3 commits into from
Closed

Fix no-dh and no-dsa #11582

wants to merge 3 commits into from

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Apr 20, 2020

Add some missing OPENSSL_NO_DH guards.

Also, one of the sub-tests in the fipsinstall test corrupts a DH test to
confirm that fipsinstall fails. However that is never noticed in a
no-dh build - so we just skip that test in a no-dh build.

mattcaswell added 2 commits Apr 20, 2020
Add some missing OPENSSL_NO_DH guards.
One of the sub-tests in the fipsinstall test corrupts a DH test to
confirm that fipsinstall fails. However that is never noticed in a
no-dh build - so we just skip that test in a no-dh build.
In a similar way to the previous commit we also skip a fipsinstall test
if DSA has been disabled.
@mattcaswell mattcaswell changed the title Fix no-dh Fix no-dh and no-dsa Apr 20, 2020
@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Apr 20, 2020

I also just added a commit to fix a closely related failure in no-dsa builds.

@slontis
Copy link
Contributor

@slontis slontis commented Apr 20, 2020

Thats an impressive amount of travis timeouts.

Why were some of these not being found as 'unresolved' in travis builds?

@t8m
t8m approved these changes Apr 21, 2020
Copy link
Member

@t8m t8m left a comment

As the Travis timeouts are unrelated I think this is OK.

openssl-machine pushed a commit that referenced this pull request Apr 22, 2020
Add some missing OPENSSL_NO_DH guards.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11582)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2020
One of the sub-tests in the fipsinstall test corrupts a DH test to
confirm that fipsinstall fails. However that is never noticed in a
no-dh build - so we just skip that test in a no-dh build.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11582)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2020
In a similar way to the previous commit we also skip a fipsinstall test
if DSA has been disabled.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11582)
@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Apr 22, 2020

Pushed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants