Fix no-dh and no-dsa #11582
Closed
Fix no-dh and no-dsa #11582
Conversation
Add some missing OPENSSL_NO_DH guards.
One of the sub-tests in the fipsinstall test corrupts a DH test to confirm that fipsinstall fails. However that is never noticed in a no-dh build - so we just skip that test in a no-dh build.
In a similar way to the previous commit we also skip a fipsinstall test if DSA has been disabled.
|
I also just added a commit to fix a closely related failure in no-dsa builds. |
|
Thats an impressive amount of travis timeouts. Why were some of these not being found as 'unresolved' in travis builds? |
|
As the Travis timeouts are unrelated I think this is OK. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 22, 2020
Add some missing OPENSSL_NO_DH guards. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #11582)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 22, 2020
One of the sub-tests in the fipsinstall test corrupts a DH test to confirm that fipsinstall fails. However that is never noticed in a no-dh build - so we just skip that test in a no-dh build. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #11582)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 22, 2020
In a similar way to the previous commit we also skip a fipsinstall test if DSA has been disabled. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #11582)
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add some missing OPENSSL_NO_DH guards.
Also, one of the sub-tests in the fipsinstall test corrupts a DH test to
confirm that fipsinstall fails. However that is never noticed in a
no-dh build - so we just skip that test in a no-dh build.