Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_cmp_vfy failures with FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION #11585

Closed
wants to merge 1 commit into from

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Apr 20, 2020

Should fix issue reported today in #11386

  • tests are added or updated
@DDvO DDvO added the urgent label Apr 20, 2020
@DDvO DDvO mentioned this pull request Apr 20, 2020
1 of 1 task complete
@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Apr 20, 2020

[extended tests]

That line needs to be in the actual commit message. Can you force push an update? Otherwise this looks good (and I agree this is urgent).

@DDvO DDvO force-pushed the siemens:fix_cmp_vfy_tests_while_fuzzing branch to 6d42dd7 Apr 20, 2020
@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 20, 2020

Oops, done.

Copy link
Member

@mattcaswell mattcaswell left a comment

Approved assuming the CIs pass (or at least don't fail in a relevant way)

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 20, 2020

So I'll merge this as soon as the CI tests passed...

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 21, 2020

All four CI failures that have been reported: https://travis-ci.org/github/openssl/openssl/builds/677315133
are not CMP related but due to some (the same?) EVP issue. So I've just merged this.

@DDvO DDvO closed this Apr 21, 2020
openssl-machine pushed a commit that referenced this pull request Apr 21, 2020
[extended tests]

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #11585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants