Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "TEST: make and use a fipsinstall script" #11592

Closed
wants to merge 1 commit into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Apr 21, 2020

Unfortunately, this won't work on MacOS because of system integrity
measures on that platform, which clears DYLD_LIBRARY_PATH before
starting a sub-process executable.

Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html

This reverts commit ae6b654.

Unfortunately, this won't work on MacOS because of system integrity
measures on that platform, which clears DYLD_LIBRARY_PATH before
starting a sub-process executable.

Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html

This reverts commit ae6b654.
@mattcaswell mattcaswell added this to Reviewer approved in 3.0 New Core + FIPS via automation Apr 21, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Apr 21, 2020

Hmmm, shouldn't this be urgent?

@t8m t8m added the urgent label Apr 21, 2020
@t8m
Copy link
Member

@t8m t8m commented Apr 21, 2020

It should.

@levitte
Copy link
Member Author

@levitte levitte commented Apr 21, 2020

I'll merge it later this afternoon

@paulidale
Copy link
Contributor

@paulidale paulidale commented Apr 21, 2020

Agreed, urgent.

openssl-machine pushed a commit that referenced this pull request Apr 21, 2020
Unfortunately, this won't work on MacOS because of system integrity
measures on that platform, which clears DYLD_LIBRARY_PATH before
starting a sub-process executable.

Ref: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html

This reverts commit ae6b654.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #11592)
@levitte
Copy link
Member Author

@levitte levitte commented Apr 21, 2020

Merged.

1e78a50 Revert "TEST: make and use a fipsinstall script"

@levitte levitte closed this Apr 21, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Apr 21, 2020
@levitte levitte deleted the levitte:remove-fipsinstall.pl branch Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants