Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info on the CMP implementation and HTTP client to NEWS and CHANGES #11608

Closed
wants to merge 1 commit into from

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Apr 22, 2020

This fixes most of #11606
and in addition mentions also the generalized HTTP client #10667, which came up along with the CMP and CRMF contribution (#7646, #11470 etc.).

  • documentation is added or updated
NEWS.md Outdated
@@ -33,6 +33,12 @@ OpenSSL 3.0
authenticate servers or clients.
* enable-crypto-mdebug and enable-crypto-mdebug-backtrace were mostly
disabled; the project uses address sanitize/leak-detect instead.
* Added a Certificate Management Protocol (CMP, RFC 4210) implementation
also covering CRMF (RFC 4211) and HTTP transfer (RFC 6712).
It is part of the crypto lib and adds a 'cmp' app with a demo configuration.

This comment has been minimized.

@mattcaswell

mattcaswell Apr 22, 2020
Member

Strictly speaking the cmp app isn't merged yet. Should we mention this now, or wait until it is there?

This comment has been minimized.

@DDvO

DDvO Apr 22, 2020
Author Contributor

Good question.
Yet I thought that this PR won't make it into the upcoming alpha release anyway?

This comment has been minimized.

@mattcaswell

mattcaswell Apr 23, 2020
Member

CHANGES and NEWS updates prior to a release are typically treated as "urgent"...in fact I'm going to add that label.

This comment has been minimized.

@DDvO

DDvO Apr 23, 2020
Author Contributor

I've rephrased the part on the app to:

while a 'cmp' app using it is in preparation.

and removed the references to the CLI app in CHANGES.md.

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 23, 2020

I'm not really sure about the order of the items in the list.
And is the amount of detail I provided about right?

@mattcaswell mattcaswell added the urgent label Apr 23, 2020
@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Apr 23, 2020

I'm not really sure about the order of the items in the list.
And is the amount of detail I provided about right?

Looks fine to me.

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 23, 2020

@mattcaswell, thanks for your quick comments.
I'd say it's ready for approval & merge..

@DDvO DDvO force-pushed the siemens:add_CMP+HTTP_NEWS_CHANGES branch to 5d1d04e Apr 23, 2020
@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 23, 2020

I've just tried to merge this, but addrev keeps saying that there is no CLA for me, regardless which of my two email addresses I provide. Is this because the repo is locked?
I've anyway squashed this PR.

Anyone having the needed privileges please do the merge.

@romen
Copy link
Member

@romen romen commented Apr 23, 2020

I've just tried to merge this, but addrev keeps saying that there is no CLA for me, regardless which of my two email addresses I provide. Is this because the repo is locked?
I've anyway squashed this PR.

Anyone having the needed privileges please do the merge.

The repo is frozen anyway, only @mattcaswell at the moment can do merges. As long as he is aware of which PRs are queued for handling before the release, he will take care of that.

openssl-machine pushed a commit that referenced this pull request Apr 23, 2020
…NGES.md

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #11608)
@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Apr 23, 2020

Pushed. There does seem to be some kind of addrev issue at the moment. I manually hacked things. The repo being frozen shouldn't affect it. But @levitte has been doing some work on the tools repo so maybe something to do with that??

@t8m
Copy link
Member

@t8m t8m commented Apr 23, 2020

Pushed. There does seem to be some kind of addrev issue at the moment. I manually hacked things. The repo being frozen shouldn't affect it. But @levitte has been doing some work on the tools repo so maybe something to do with that??

Yeah, still happens for me as well. The OpenSSL::Query does not work.

@levitte
Copy link
Member

@levitte levitte commented Apr 24, 2020

Please try again. There was a web configuration error, which I corrected early this morning.

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Apr 25, 2020

Please try again. There was a web configuration error, which I corrected early this morning.

Thanks @levitte, addrev works again.

@DDvO DDvO deleted the siemens:add_CMP+HTTP_NEWS_CHANGES branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants