Various code fixes #1168
Closed
Various code fixes #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FdaSilvaYY
force-pushed
the
various-fixes2
branch
3 times, most recently
from
75adee3
to
eaddb2f
Compare
| @@ -45,22 +45,21 @@ int BIO_set(BIO *bio, const BIO_METHOD *method) | |||
| bio->references = 1; | |||
| bio->num_read = 0L; | |||
| bio->num_write = 0L; | |||
| if (!CRYPTO_new_ex_data(CRYPTO_EX_INDEX_BIO, bio, &bio->ex_data)) | |||
| return 0; | |||
|
|
|||
| bio->lock = CRYPTO_THREAD_lock_new(); | |||
There was a problem hiding this comment.
one thing to consider is have a static BIO object with initializers and then do an assignment, to get the initializatoin. If not that, then just doing memset() and setting the non-zero pointers is better. while you're in this part of the code.
There was a problem hiding this comment.
I don't understand the code-meaning of your 1st sentence.
Will reading this code, I also think that the initialisation code should be moved to BIO_new().
Let's do it...
There was a problem hiding this comment.
static BIO nilb = { 0, 0, 0, -1L, 0, 0, …. Etc }
*b = nil;
37ba2a7
to
c165cc2
Compare
FdaSilvaYY
force-pushed
the
various-fixes2
branch
7 times, most recently
from
61ec7a8
to
e622b05
Compare
FdaSilvaYY
force-pushed
the
various-fixes2
branch
4 times, most recently
from
a9950dc
to
4edbdfc
Compare
FdaSilvaYY
force-pushed
the
various-fixes2
branch
from
4edbdfc
to
2e4f06d
Compare
FdaSilvaYY
force-pushed
the
various-fixes2
branch
from
2e4f06d
to
3ec9891
Compare
|
+1 |
kroeckx
added
the
approval: done
|
merged, thanks. |
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2016
Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1168)
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2016
Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1168)
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2016
Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1168)
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2016
Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1168)
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2016
Reviewed-by: Kurt Roeckx <kurt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I push a large code change out of this PR, to minimize the review work to do .