OSSL_STORE additions #11756
OSSL_STORE additions #11756
Conversation
|
I made this WIP for the moment, to clear the Travis failures |
crypto/err/openssl.txt
Outdated
Show resolved
Hide resolved
crypto/err/openssl.txt
Outdated
Show resolved
Hide resolved
crypto/store/loader_file.c
Outdated
Show resolved
Hide resolved
crypto/store/loader_file.c
Outdated
Show resolved
Hide resolved
crypto/store/store_lib.c
Outdated
Show resolved
Hide resolved
include/openssl/store.h
Outdated
Show resolved
Hide resolved
|
Thanks @levitte for quickly de-coupling these changes for use in #11755. I appreciate the flexibility it provides w.r.t. custom BIO input and the added MSBLOB and PVK support, which will allow further strong simplification of the loading functions adapted in #11755, |
|
Is my review sufficient in this case? |
It that's about my lack of interaction, I had some personal time during the day... |
|
This is now out of WIP |
|
Great that you meanwhile fixed those (mostly minor) issues. |
This capability existed internally, and is now made public.
The prompt includes the URI, to make it clear which object needs a pass phrase.
This involves exposing two pvkfmt.c functions, but only internally.
|
Still the
|
Ah, thanks. Fixed |
|
Sigh, now doc-nits mourns:
I think it needs to be listed in It's advisable (but I also tend to forget) to run |
Silly find-doc-nits can't properly parse typedefs... :-/ I added a line in other.syms |
|
The changes I had requested are meanwhile done. So I wanted to change my review outcome to "approved", but GitHub seems to have lost my review state :-( |
Yes, your approval counts. PRs need one OTC approval and one commiter approval - and the author "counts". Since, @levitte is an OTC member he just needs one committer approval. In any case "extra" approvals are useful to show what review a PR has gone throug. |
|
LGTM |
|
@levitte, I think this can be merged now. |
This capability existed internally, and is now made public. Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from #11756)
The prompt includes the URI, to make it clear which object needs a pass phrase. Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from #11756)
This involves exposing two pvkfmt.c functions, but only internally. Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from #11756)
Additions that I've had lying around in #7390 but are hopefully interesting on their own.
OSSL_STORE: Make it possible to attach an OSSL_STORE to an opened BIO
This capability existed internally, and is now made public.
OSSL_STORE: Better information when prompting for pass phrases
The prompt includes the URI, to make it clear which object needs a
pass phrase.
OSSL_STORE: Make the 'file' scheme loader handle MSBLOB and PVK files
This involves exposing two pvkfmt.c functions, but only internally.