[test] ectest: check custom generators #12096
Closed
Conversation
|
I missed this before! This is supposed to be also in |
|
LGTM, I can confirm this cherry picks cleanly to 1.1.1 so far. |
|
This is holding up #12201, which still needs effort after this gets merged. Can I get a second review please? |
|
LGTM |
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 12, 2020
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #12096)
|
Merged to both branches. Thanks! |
Closed
romen
added a commit
to romen/openssl
that referenced
this pull request
Jul 13, 2020
Backport of openssl#12096 to 1.1.1 broke the build as the following functions are missing: const BIGNUM *EC_GROUP_get0_field(const EC_GROUP *group); int EC_GROUP_get_field_type(const EC_GROUP *group); Turns out that for the purposes of the test code, we don't really need to differentiate between prime and binary fields, and we can directly use the existing `EC_GROUP_get_degree()` in the same fashion as was being done for binary fields also for prime fields. Fixes openssl#12432
openssl-machine
pushed a commit
that referenced
this pull request
Jul 14, 2020
Backport of #12096 to 1.1.1 broke the build as the following functions are missing: const BIGNUM *EC_GROUP_get0_field(const EC_GROUP *group); int EC_GROUP_get_field_type(const EC_GROUP *group); Turns out that for the purposes of the test code, we don't really need to differentiate between prime and binary fields, and we can directly use the existing `EC_GROUP_get_degree()` in the same fashion as was being done for binary fields also for prime fields. Fixes #12432 Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #12433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I was doing some custom
EC_METHODwork that should've obviously failed because it was oblivious toEC_GROUP_set_generator.But it passed all tests.
So here's a PR for that.
A handful of the NIST curves have similar tests in
ectest.cthat I'll deprecate as part of a larger cleanup of this test harness in the future.