Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: avoid memory overrun. #12258

Closed
wants to merge 1 commit into from
Closed

Conversation

@paulidale
Copy link
Contributor

@paulidale paulidale commented Jun 24, 2020

NULL terminate the built in "help" argv array to avoid reading beyond the end.

Fixes #12246

Pauli
NULL terminate the built in "help" argv array to avoid reading beyond the
end.
@paulidale
Copy link
Contributor Author

@paulidale paulidale commented Jun 24, 2020

This should address the read overrun -fsanitize=address failures.
It does reproduce locally for me.

Urgent because the CIs are broken.

@beldmit
Copy link
Member

@beldmit beldmit commented Jun 24, 2020

Approved if CI is happy

openssl-machine pushed a commit that referenced this pull request Jun 24, 2020
NULL terminate the built in "help" argv array to avoid
reading beyond the end.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from #12258)
@mspncp
Copy link
Contributor

@mspncp mspncp commented Jun 24, 2020

Merged.

@mspncp mspncp closed this Jun 24, 2020
@paulidale
Copy link
Contributor Author

@paulidale paulidale commented Jun 24, 2020

Thanks for merging this one.

@mspncp
Copy link
Contributor

@mspncp mspncp commented Jun 24, 2020

You're welcome!

Copy link
Contributor

@slontis slontis left a comment

Sigh!!.. Not sure why this was not detected until subsequent test runs afterwards.. Did some settings change?

@paulidale
Copy link
Contributor Author

@paulidale paulidale commented Jun 25, 2020

I suspect it is an incompatibility between two independent PRs.

@paulidale paulidale deleted the paulidale:app-fix-argv branch Jul 14, 2020
@paulidale paulidale restored the paulidale:app-fix-argv branch Jul 14, 2020
@paulidale paulidale deleted the paulidale:app-fix-argv branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants