apps: avoid memory overrun. #12258
Closed
apps: avoid memory overrun. #12258
Conversation
NULL terminate the built in "help" argv array to avoid reading beyond the end.
|
This should address the read overrun Urgent because the CIs are broken. |
|
Approved if CI is happy |
This was referenced Jun 24, 2020
openssl-machine
pushed a commit
that referenced
this pull request
Jun 24, 2020
NULL terminate the built in "help" argv array to avoid reading beyond the end. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from #12258)
|
Merged. |
|
Thanks for merging this one. |
|
You're welcome! |
|
Sigh!!.. Not sure why this was not detected until subsequent test runs afterwards.. Did some settings change? |
|
I suspect it is an incompatibility between two independent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NULL terminate the built in "help"
argvarray to avoid reading beyond the end.Fixes #12246