Improve error diagnostics of X509V3 conf parsing, CMP, and other apps #12296
Conversation
apps/lib/apps.c
Outdated
Show resolved
Hide resolved
crypto/objects/obj_dat.c
Outdated
Show resolved
Hide resolved
crypto/x509/v3_cpols.c
Outdated
Show resolved
Hide resolved
include/openssl/x509v3.h
Outdated
Show resolved
Hide resolved
apps/lib/apps.c
Outdated
Show resolved
Hide resolved
|
Thanks @paulidale for reviewing this. |
|
The Travis builds have been queued, for whatever strange reason, for two days. |
|
@paulidale, can you still have a quick look at the changes you requested and my reaction and approve that before you leave? In any case, have a nice and restful vacation! |
|
This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago |
|
LGTM. Apologies for the delay, another slipped through the cracks. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
…ion:<NULL>' etc. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
…Y_NAME Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
…s appropriate Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 4, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #12296)
|
Merged - thanks @paulidale |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
…ion:<NULL>' etc. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
…Y_NAME Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
…s appropriate Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Fixes openssl#12268 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes #12268
and various other small issues I recently found using the CMP CLI and other apps:
the diagnostics was:
With the fixes done here, this becomes:
parse_name()inapps/lib/apps.capps/cmp.con server+proxy to be contacted.