[1.1.1][test][15-test_genec] Improve EC tests with genpkey #12308
Conversation
…ters and keys The following built-in curves do not have an assigned OID: - Oakley-EC2N-3 - Oakley-EC2N-4 In general we shouldn't assume that an OID is always available. This commit detects such cases, raises an error and returns appropriate return values so that the condition can be detected and correctly handled by the callers, when serializing EC parameters or EC keys with the default `ec_param_enc:named_curve`. Fixes #12306 (cherry picked from commit e810483)
… parameters and keys make update (cherry picked from commit 342e858)
If the key is to be serialized or printed as text and the framework returns an error, the app should signal the failure to the user using a non-zero exit status. (cherry picked from commit a2bce31)
(cherry picked from commit c2d5625)
…put errors (cherry picked from commit cedac7e)
Test separately EC parameters and EC key generation. For some curves we have had cases in which generating the parameters under certain conditions failed, while generating and serializing a key under the same conditions did not. See <#12306> for more details.
[test][15-test_genec] Some curves only support explicit params encoding
|
@mattcaswell can you spare some time to look at this as well? |
|
This was approved at
It will be ready to merge at |
romen
added a commit
to romen/openssl
that referenced
this pull request
Jul 4, 2020
Test separately EC parameters and EC key generation. Some curves only support explicit params encoding. For some curves we have had cases in which generating the parameters under certain conditions failed, while generating and serializing a key under the same conditions did not. See <openssl#12306> for more details. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#12308)
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 7, 2020
Test separately EC parameters and EC key generation. Some curves only support explicit params encoding. For some curves we have had cases in which generating the parameters under certain conditions failed, while generating and serializing a key under the same conditions did not. See <#12306> for more details. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #12308)
|
Merged to
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is related to #12307 (does the same thing for
master) but is opened against1.1.1because the backport is not trivial due to the need forTODO: {}annotations until #12102 is fixed.Checklist