Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free pre_proc_exts. #12330

Closed
wants to merge 1 commit into from
Closed

Free pre_proc_exts. #12330

wants to merge 1 commit into from

Conversation

@mkaniewski
Copy link
Contributor

@mkaniewski mkaniewski commented Jun 30, 2020

Usually it will be freed in tls_early_post_process_client_hello().
However if a ClientHello callback will be used and will return
SSL_CLIENT_HELLO_RETRY then tls_early_post_process_client_hello()
may never come to the point where pre_proc_exts is freed.

Fixes #12194

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated
Usually it will be freed in tls_early_post_process_client_hello().
However if a ClientHello callback will be used and will return
SSL_CLIENT_HELLO_RETRY then tls_early_post_process_client_hello()
may never come to the point where pre_proc_exts is freed.

Fixes #12194

CLA: trivial
@kaduk
kaduk approved these changes Jun 30, 2020
Copy link
Contributor

@kaduk kaduk left a comment

Thanks for putting this together.

Formality: I agree this is trivial

Copy link
Contributor

@paulidale paulidale left a comment

Agreed trivial

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Jul 2, 2020

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jul 2, 2020
Usually it will be freed in tls_early_post_process_client_hello().
However if a ClientHello callback will be used and will return
SSL_CLIENT_HELLO_RETRY then tls_early_post_process_client_hello()
may never come to the point where pre_proc_exts is freed.

Fixes #12194

CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #12330)
openssl-machine pushed a commit that referenced this pull request Jul 2, 2020
Usually it will be freed in tls_early_post_process_client_hello().
However if a ClientHello callback will be used and will return
SSL_CLIENT_HELLO_RETRY then tls_early_post_process_client_hello()
may never come to the point where pre_proc_exts is freed.

Fixes #12194

CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #12330)

(cherry picked from commit 94941ca)
@kaduk
Copy link
Contributor

@kaduk kaduk commented Jul 2, 2020

Merged to master and 1.1.1, so closing.
Thanks for the submission!

@kaduk kaduk closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants