Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81-test_cmp_cli.t: Skip tests with mock server if server cannot be started #12537

Closed
wants to merge 1 commit into from

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Jul 27, 2020

It turns out that there are still issues launching a server reliably on non-Linux platforms
without proper support by a Perl module such as Proc::Background.
This PR now simply skps the tests that need the mock server
if launching the server process or determining its PID goes wrong for any reason.

Fixes #12514

  • tests are added or updated
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Aug 1, 2020

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Aug 3, 2020

Merged - thanks @paulidale

@DDvO DDvO closed this Aug 3, 2020
openssl-machine pushed a commit that referenced this pull request Aug 3, 2020
…arted

Fixes #12514

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #12537)
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
…arted

Fixes openssl#12514

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#12537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants