81-test_cmp_cli.t: Skip tests with mock server if server cannot be started #12537
Conversation
|
This pull request is ready to merge |
|
Merged - thanks @paulidale |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
…arted Fixes openssl#12514 Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from openssl#12537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It turns out that there are still issues launching a server reliably on non-Linux platforms
without proper support by a Perl module such as
Proc::Background.This PR now simply skps the tests that need the mock server
if launching the server process or determining its PID goes wrong for any reason.
Fixes #12514