Coverity Fixes for issue #12531 #12557
Closed
Conversation
Fixes #12531 on master branch.
| dest->parameter = ASN1_TYPE_new(); | ||
| if (dest->parameter == NULL) | ||
| return 0; | ||
|
|
||
| /* Assuming this is also correct for a BOOL. |
slontis
Jul 30, 2020
•
Contributor
And here
/*
* Assuming
And here
/*
* Assuming
Updated per review.
|
Thanks for your patience.. |
|
No worries at all.
On Jul 29, 2020, at 9:18 PM, Shane <notifications@github.com<mailto:notifications@github.com>> wrote:
@slontis approved this pull request.
Thanks for your patience..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12557 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFSCNZMDFKSKJQJWA4ABOD3R6DC6ZANCNFSM4PLXUDZQ>.
|
|
This pull request is ready to merge |
|
Thanks for fixing. Merged to master. |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Fixes openssl#12531 on master branch. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from openssl#12557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #12531 on master branch.
Address comments from
#12531
Checklist