Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity Fixes for issue #12531 #12557

Closed
wants to merge 2 commits into from
Closed

Conversation

@ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Jul 29, 2020

Fixes #12531 on master branch.
Address comments from
#12531

Checklist
  • documentation is added or updated
  • tests are added or updated
Fixes #12531 on master branch.
crypto/asn1/x_algor.c Outdated Show resolved Hide resolved
dest->parameter = ASN1_TYPE_new();
if (dest->parameter == NULL)
return 0;

/* Assuming this is also correct for a BOOL.

This comment has been minimized.

@slontis

slontis Jul 30, 2020
Contributor

And here

/*
 * Assuming
Updated per review.
Copy link
Contributor

@slontis slontis left a comment

Thanks for your patience..

@ashman-p
Copy link
Contributor Author

@ashman-p ashman-p commented Jul 30, 2020

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Jul 31, 2020

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Aug 4, 2020
Fixes #12531 on master branch.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #12557)
@slontis
Copy link
Contributor

@slontis slontis commented Aug 4, 2020

Thanks for fixing. Merged to master.

@slontis slontis closed this Aug 4, 2020
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
Fixes openssl#12531 on master branch.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#12557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants