Avoid segfault in SSL_export_keying material if there is no session #12594
Conversation
|
Can we add a test for this in |
|
Will do. |
|
Added |
|
LGTM |
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 13, 2020
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #12594)
|
Merged to master and 1.1.1 |
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Fixes openssl#12588 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#12594)
swenkeratmicrosoft
pushed a commit
to swenkeratmicrosoft/openssl
that referenced
this pull request
Sep 1, 2020
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#12594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #12588
Not sure if this fixes all the possible cases of segfaulting in SSL_export_keying_material. But at least it fixes the example case in the bug report.