Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROV: Fix MSBLOB / PVK deserializer #12601

Closed
wants to merge 1 commit into from
Closed

PROV: Fix MSBLOB / PVK deserializer #12601

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Aug 7, 2020

No description provided.

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Aug 7, 2020
@levitte levitte added this to In progress in 3.0 New Core + FIPS via automation Aug 7, 2020
@levitte
Copy link
Member Author

levitte commented Aug 7, 2020

#12581 and #12574 weren't in sync when merged...

@levitte levitte added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Aug 7, 2020
paulidale
paulidale approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't added the unused note to the params gettable/settable functions.
I'll add a PR.

3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Aug 7, 2020
@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Aug 7, 2020
@levitte
Copy link
Member Author

levitte commented Aug 7, 2020

I wasn't added the unused note to the params gettable/settable functions.

I forget it all the time as well...

openssl-machine pushed a commit that referenced this pull request Aug 7, 2020
@levitte
PROV: Fix MSBLOB / PVK deserializer
4df0d37 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #12601)
@levitte
Copy link
Member Author

levitte commented Aug 7, 2020

Merged

4df0d37 PROV: Fix MSBLOB / PVK deserializer

@levitte levitte closed this Aug 7, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Aug 7, 2020
@levitte levitte deleted the fix-msblob-and-pvk-deserializers branch August 7, 2020 03:14
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
@levitte
PROV: Fix MSBLOB / PVK deserializer
87ba5ce 
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#12601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
No open projects
3.0 New Core + FIPS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@levitte @paulidale