Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configdata.pm.in: Make a HERE document stricter. #13225

Closed
wants to merge 2 commits into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Oct 23, 2020

Fixes #13221
Fixes #12743
Fixes #12078

Fixes #13221
Fixes #12743
Fixes #12078
@levitte levitte modified the milestone: 3.0.0 Oct 23, 2020
@levitte levitte changed the title configdata.pm.in: Make a HERE document stricter. [WIP] configdata.pm.in: Make a HERE document stricter. Oct 23, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Oct 23, 2020

This is WIP until confirmed to fix the issues

Copy link
Contributor

@paulidale paulidale left a comment

Assuming that this fixes the problems.

... and util/dofile.pl
@levitte levitte dismissed paulidale’s stale review Oct 25, 2020

Not quite... another similar fix added

@t-j-h
t-j-h approved these changes Oct 25, 2020
@jeroen
jeroen approved these changes Oct 25, 2020
Copy link

@jeroen jeroen left a comment

Fixes my problem, thank you!

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Oct 26, 2020

This pull request is ready to merge

Copy link

@Croydon Croydon left a comment

Works for Conan

@levitte levitte changed the title [WIP] configdata.pm.in: Make a HERE document stricter. configdata.pm.in: Make a HERE document stricter. Oct 27, 2020
openssl-machine pushed a commit that referenced this pull request Oct 27, 2020
Fixes #13221
Fixes #12743
Fixes #12078

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #13225)
@levitte
Copy link
Member Author

@levitte levitte commented Oct 27, 2020

Merged

09803e9 configdata.pm.in, util/dofile.pl: Make a HERE document stricter.

@levitte levitte closed this Oct 27, 2020
@levitte levitte deleted the levitte:fix-config-atsign branch Oct 27, 2020
Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants