Convert dhparam so that it no longer needs low level APIs #13231
Conversation
Closed
Previously changes left some variables behind that were no longer needed. We now remove them.
|
Now that #13228 has gone in I have taken this out of WIP and rebased it to resolve conflicts with master. I have also removed the commits that dealt with removing the "-C" option since that was already handled by #13384. The OMC hold that was on this PR was related to that part of the change so I've also removed the hold. This is now ready for review. Please take a look. |
|
Ping? |
|
Hmm. Travis failure - fixup pushed. I definitely already did that same fixup yesterday - but somehow I lost it. |
|
Fixup pushed to address a travis failure. @paulidale - please can you reconfirm? |
|
Still good. |
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #13231)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #13231)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2020
Previously changes left some variables behind that were no longer needed. We now remove them. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #13231)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2020
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #13231)
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This converts the dhparam app so that it no longer needs to use any low level APIs, as well as adding a test to check that the behaviour is consistent with historic behaviour.
It does not address the issue that stdin does not currently work with the app (as described in issue #13185).
It is marked as pending because it requires the commits from #13228. Those commits are not included in this PR to ease review, but this means that the new test will fail.
I've also added an OMC hold on this because, in accordance with the recent OTC decision the "-C" option has been removed. However that decision needs OMC ratification.
Note that I developed and tested the new test in the 1.1.1 branch first. However I had to change it to get it to work in master because of subtle differences in the way the "-text" output works between the two versions (as per issue #13220).