Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defltprov: remove duplicate algorithm names. #13308

Closed
wants to merge 1 commit into from

Conversation

@paulidale
Copy link
Contributor

@paulidale paulidale commented Nov 4, 2020

Ed25519 and Ed448 contained aliases that were the same as the primary name.
This removes the aliases leaving ED25519 and ED448 as the canonical names.

Matching is case insensitive, so no functionality is lost. The FIPS provider
didn't include the duplicates.

Ed25519 and Ed448 contained aliases that were the same as the primary name.
This removes the aliases leaving ED25519 and ED448 as the canonical names.

Matching is case insensitive, so no functionality is lost.  The FIPS provider
didn't include the duplicates.
@paulidale paulidale self-assigned this Nov 4, 2020
@paulidale paulidale added this to In progress in 3.0 New Core + FIPS via automation Nov 4, 2020
@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Nov 4, 2020

The aliases differ in case. Isn't that significant?

Copy link
Member

@mattcaswell mattcaswell left a comment

Oh....now I read your original description properly. So ... approved.

3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Nov 4, 2020
@paulidale
Copy link
Contributor Author

@paulidale paulidale commented Nov 5, 2020

Merged to master, thanks.

@paulidale paulidale closed this Nov 5, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Nov 5, 2020
@paulidale paulidale deleted the paulidale:undup-names branch Nov 5, 2020
openssl-machine pushed a commit that referenced this pull request Nov 5, 2020
Ed25519 and Ed448 contained aliases that were the same as the primary name.
This removes the aliases leaving ED25519 and ED448 as the canonical names.

Matching is case insensitive, so no functionality is lost.  The FIPS provider
didn't include the duplicates.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants