ERR: deprecate all old ERR_load_ and stop producing new ones #13390
Conversation
include/openssl/cryptoerr.h
Outdated
Show resolved
Hide resolved
CHANGES.md
Outdated
Show resolved
Hide resolved
util/libcrypto.num
Outdated
Show resolved
Hide resolved
util/libcrypto.num
Outdated
Show resolved
Hide resolved
util/missingcrypto.txt
Outdated
Show resolved
Hide resolved
|
This partially addresses #13192 |
|
CIs are happy, so time for a final review? |
|
Is this the PR related to issue #10527? |
|
Ah, yes, thanks for reminding me |
|
Ping |
This also modifies the .ec L statement to take a third file, which is the internal header file to declare internal things. This is only useful for our internal declarations and will not affect engines.
This deprecates all the ERR_load_ functions, and moves their definition to separate C source files that can easily be removed when those functions are finally removed.
This is the result of 'make errors ERROR_REBUILD=-rebuild'
…loaders This also reduces include/openssl/kdferr.h to include cryptoerr_legacy.h, and moves the declaration of ERR_load_ERR_strings() from include/openssl/err.h to include/openssl/cryptoerr_legacy.h.
…loaders ... also removes the declaration of ERR_load_DSO_strings(), which was entirely internal anyway.
This reverts commit a308acb.
This was referenced Nov 20, 2020
New message: Add missing ERR_load_KDF_strings(3) to util/missingcrypto111.txt as well. This partially reverts commit a308acb.
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2020
This deprecates all the ERR_load_ functions, and moves their definition to separate C source files that can easily be removed when those functions are finally removed. This also reduces include/openssl/kdferr.h to include cryptoerr_legacy.h, moves the declaration of ERR_load_ERR_strings() from include/openssl/err.h to include/openssl/cryptoerr_legacy.h, and finally removes the declaration of ERR_load_DSO_strings(), which was entirely internal anyway. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #13390)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2020
This is the result of 'make errors ERROR_REBUILD=-rebuild' Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #13390)
|
Merged 9343d3f ERR: Modify util/mkerr.pl to produce internal err string loaders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is done by collecting all the pre-3.0
ERR_load_function declarations in separate legacy header files, and re-implement them in terms of internal functions.The way we now load all the strings in the libraries is through internal functions.
This removes the need to document generated functions that we don't use or want to publish.
Fixes #10527