Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: deprecate all old ERR_load_ and stop producing new ones #13390

Closed
wants to merge 24 commits into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Nov 12, 2020

This is done by collecting all the pre-3.0 ERR_load_ function declarations in separate legacy header files, and re-implement them in terms of internal functions.

The way we now load all the strings in the libraries is through internal functions.

This removes the need to document generated functions that we don't use or want to publish.

Fixes #10527

include/openssl/cryptoerr.h Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
include/crypto/asn1err.h Show resolved Hide resolved
util/libcrypto.num Outdated Show resolved Hide resolved
util/libcrypto.num Outdated Show resolved Hide resolved
util/missingcrypto.txt Outdated Show resolved Hide resolved
@slontis
Copy link
Contributor

@slontis slontis commented Nov 12, 2020

This partially addresses #13192

@levitte
Copy link
Member Author

@levitte levitte commented Nov 16, 2020

CIs are happy, so time for a final review?

@slontis
Copy link
Contributor

@slontis slontis commented Nov 17, 2020

Is this the PR related to issue #10527?

@levitte
Copy link
Member Author

@levitte levitte commented Nov 17, 2020

Ah, yes, thanks for reminding me

@levitte
Copy link
Member Author

@levitte levitte commented Nov 17, 2020

Ping

levitte added 16 commits Nov 12, 2020
This also modifies the .ec L statement to take a third file, which is
the internal header file to declare internal things.  This is only
useful for our internal declarations and will not affect engines.
This deprecates all the ERR_load_ functions, and moves their definition to
separate C source files that can easily be removed when those functions are
finally removed.
This is the result of 'make errors ERROR_REBUILD=-rebuild'
…loaders

This also reduces include/openssl/kdferr.h to include cryptoerr_legacy.h,
and moves the declaration of ERR_load_ERR_strings() from include/openssl/err.h
to include/openssl/cryptoerr_legacy.h.
…loaders

... also removes the declaration of ERR_load_DSO_strings(), which was
entirely internal anyway.
engines/e_dasync_err.h Show resolved Hide resolved
util/missingcrypto.txt Show resolved Hide resolved
New message:

Add missing ERR_load_KDF_strings(3) to util/missingcrypto111.txt as well.

This partially reverts commit a308acb.
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 24, 2020

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
This also modifies the .ec L statement to take a third file, which is
the internal header file to declare internal things.  This is only
useful for our internal declarations and will not affect engines.

Fixes #10527

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13390)
openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
This deprecates all the ERR_load_ functions, and moves their definition to
separate C source files that can easily be removed when those functions are
finally removed.

This also reduces include/openssl/kdferr.h to include cryptoerr_legacy.h,
moves the declaration of ERR_load_ERR_strings() from include/openssl/err.h
to include/openssl/cryptoerr_legacy.h, and finally removes the declaration
of ERR_load_DSO_strings(), which was entirely internal anyway.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13390)
openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
This is the result of 'make errors ERROR_REBUILD=-rebuild'

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13390)
openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
…ell.

This partially reverts commit a308acb.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13390)
@levitte
Copy link
Member Author

@levitte levitte commented Nov 24, 2020

Merged

9343d3f ERR: Modify util/mkerr.pl to produce internal err string loaders
f5a46ed Modify the ERR init functions to use the internal ERR string loaders
14a6c6a ERR: Rebuild all generated error headers and source files
273144f Add missing ERR_load_KDF_strings(3) to util/missingcrypto111.txt as well.

@levitte levitte closed this Nov 24, 2020
@levitte levitte deleted the levitte:fix-err-legacy-20201112 branch Nov 24, 2020
@nelsonopenssl nelsonopenssl added this to Ready to merge in 3.0.0 estimator Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.0 estimator
Ready to merge
Linked issues

Successfully merging this pull request may close these issues.

7 participants