Fix crash in genpkey app when -pkeyopt digest:name is used for DH/DSA #13432
Conversation
…DSA. By the time the keygen is called the references to strings inside the gen ctx are floating pointers. A strdup solves this problem.
|
|
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 20, 2020
…DSA. By the time the keygen is called the references to strings inside the gen ctx are floating pointers. A strdup solves this problem. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #13432)
|
Thanks. Merged to master. |
clin1234
added a commit
to clin1234/openssl
that referenced
this pull request
Nov 21, 2020
…DSA. By the time the keygen is called the references to strings inside the gen ctx are floating pointers. A strdup solves this problem. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#13432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
By the time the keygen is called the references to strings inside the
gen ctx are floating pointers. A strdup solves this problem.
Found whilst checking that truncated SHA worked for keygen.
Checklist