Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in genpkey app when -pkeyopt digest:name is used for DH/DSA #13432

Closed
wants to merge 1 commit into from

Conversation

@slontis
Copy link
Contributor

@slontis slontis commented Nov 18, 2020

By the time the keygen is called the references to strings inside the
gen ctx are floating pointers. A strdup solves this problem.

Found whilst checking that truncated SHA worked for keygen.

Checklist
  • documentation is added or updated
  • tests are added or updated
…DSA.

By the time the keygen is called the references to strings inside the
gen ctx are floating pointers. A strdup solves this problem.
Copy link
Contributor

@paulidale paulidale left a comment

👍

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 19, 2020

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 20, 2020
…DSA.

By the time the keygen is called the references to strings inside the
gen ctx are floating pointers. A strdup solves this problem.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13432)
@slontis
Copy link
Contributor Author

@slontis slontis commented Nov 20, 2020

Thanks. Merged to master.

@slontis slontis closed this Nov 20, 2020
clin1234 added a commit to clin1234/openssl that referenced this pull request Nov 21, 2020
…DSA.

By the time the keygen is called the references to strings inside the
gen ctx are floating pointers. A strdup solves this problem.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#13432)
@nelsonopenssl nelsonopenssl added this to Ready to merge in 3.0.0 estimator Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.0 estimator
Ready to merge
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants