Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509_vfy.c: Remove superfluous assignment to 'ret' in check_chain() #13458

Closed

Conversation

@seardes
Copy link
Contributor

@seardes seardes commented Nov 20, 2020

This fixes #13354 referring to Coverity CID 1469104.

Three superfluous assignments to ret in check_chain() removed.

On this occasion we also fix a whitespace nit in check_chain().

@paulidale
Copy link
Contributor

@paulidale paulidale commented Nov 20, 2020

If you consider these changes to be trivial, please add CLA: trivial to the commit message. If not, we'll need you to fill in an ICLA and possibly an updated CCLA from your employer.

For the record, I'm okay calling these changes trivial.

@seardes seardes force-pushed the siemens:fix_13354_Coverity_CID_1469104 branch to 619e058 Nov 20, 2020
Copy link
Member

@mattcaswell mattcaswell left a comment

Approved. I agree this is trivial.

@paulidale are you ok with backporting this to 1.1.1?

@seardes
Copy link
Contributor Author

@seardes seardes commented Nov 20, 2020

If you consider these changes to be trivial, please add CLA: trivial to the commit message. If not, we'll need you to fill in an ICLA and possibly an updated CCLA from your employer.

For the record, I'm okay calling these changes trivial.

Thanks @paulidale for your immediate approval and comment on the CLA.
When submitting my PR I initially used not the right email address.
I've meanwhile corrected this using a forced push.
Now the CLA has been recognized correctly.

@DDvO
Copy link
Contributor

@DDvO DDvO commented Nov 20, 2020

CIFuzz failure is unrelated, so @seardes you can ignore that.

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 21, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@DDvO
Copy link
Contributor

@DDvO DDvO commented Nov 22, 2020

Travis is stuck even before doing any builds since nearly 2 days. Is this currently a general phenomenon?
Closing and re-opening this PR to kick Travis; hope this helps.

@DDvO DDvO closed this Nov 22, 2020
@DDvO DDvO reopened this Nov 22, 2020
openssl-machine pushed a commit that referenced this pull request Nov 22, 2020
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #13458)
@paulidale
Copy link
Contributor

@paulidale paulidale commented Nov 22, 2020

I don't think this needs to go to 1.1.1 after all.

I've merged it to master.

@paulidale paulidale closed this Nov 22, 2020
@DDvO
Copy link
Contributor

@DDvO DDvO commented Nov 22, 2020

I don't think this needs to go to 1.1.1 after all.

Yes, this would have made sense (only) if commit 3309c4b had been backported.

I've merged it to master.

Thanks @paulidale.

So closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants